Skip to content

fix: App Store compatible icons#926

Merged
kirillzyusko merged 5 commits intomainfrom
fix/app-store-compilant-icons
Apr 21, 2025
Merged

fix: App Store compatible icons#926
kirillzyusko merged 5 commits intomainfrom
fix/app-store-compilant-icons

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Apr 21, 2025

📜 Description

Remove transparency around borders to meet App Store requirements.

💡 Motivation and Context

I'd like to have an ability to submit app to App Store to see if codebase has any violations.

📢 Changelog

Example

  • remove icon transparency

🤔 How Has This Been Tested?

Tested via App Store submit.

📸 Screenshots (if appropriate):

image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added the example Anything related to example project label Apr 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 26.5%, saving 245.35 KB.

Filename Before After Improvement Visual comparison
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/100.png 6.54 KB 5.45 KB -16.7% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/102.png 6.74 KB 5.49 KB -18.6% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/1024.png 504.71 KB 354.28 KB -29.8% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/108.png 7.25 KB 5.89 KB -18.7% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/114.png 7.96 KB 6.38 KB -19.8% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/120.png 8.67 KB 7.05 KB -18.7% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/128.png 9.41 KB 7.64 KB -18.8% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/144.png 11.53 KB 9.32 KB -19.2% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/152.png 12.27 KB 10.00 KB -18.5% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/16.png 595 bytes 566 bytes -4.9% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/167.png 13.80 KB 10.89 KB -21.1% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/172.png 15.03 KB 11.75 KB -21.8% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/180.png 16.24 KB 12.61 KB -22.3% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/196.png 18.71 KB 14.51 KB -22.4% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/216.png 22.12 KB 16.85 KB -23.8% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/234.png 25.16 KB 19.18 KB -23.8% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/256.png 29.87 KB 22.56 KB -24.5% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/258.png 30.30 KB 22.96 KB -24.2% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/29.png 1.29 KB 1.15 KB -11.3% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/32.png 1.38 KB 1.27 KB -7.6% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/40.png 1.87 KB 1.69 KB -9.9% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/48.png 2.35 KB 2.11 KB -10.3% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/50.png 2.51 KB 2.19 KB -12.7% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/512.png 122.35 KB 88.88 KB -27.4% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/55.png 2.81 KB 2.38 KB -15.5% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/57.png 2.95 KB 2.50 KB -15.3% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/58.png 2.90 KB 2.48 KB -14.6% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/60.png 3.16 KB 2.71 KB -14.2% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/64.png 3.36 KB 2.95 KB -12.2% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/66.png 3.48 KB 3.04 KB -12.6% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/72.png 4.07 KB 3.48 KB -14.4% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/76.png 4.40 KB 3.74 KB -15.0% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/80.png 4.74 KB 4.06 KB -14.3% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/87.png 5.30 KB 4.38 KB -17.3% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/88.png 5.47 KB 4.55 KB -16.9% View diff
ios/KeyboardControllerNative/KeyboardControllerNative/Assets.xcassets/AppIcon.appiconset/92.png 5.85 KB 4.86 KB -17.0% View diff

169 images did not require optimisation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2025

📊 Package size report

Current size Target Size Difference
177761 bytes 177761 bytes 0 bytes 📉

@kirillzyusko kirillzyusko marked this pull request as ready for review April 21, 2025 12:36
@kirillzyusko kirillzyusko merged commit 59dddfe into main Apr 21, 2025
19 checks passed
@kirillzyusko kirillzyusko deleted the fix/app-store-compilant-icons branch April 21, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

example Anything related to example project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant